Skip to content

Conversation

@wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Nov 24, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2025
@qiancai qiancai self-assigned this Nov 25, 2025
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@qiancai
Copy link
Collaborator

qiancai commented Nov 26, 2025

add the do-not-merge/hold label as the change in this PR won't be included in v8.5.4

@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Nov 26, 2025
Co-authored-by: Ruihao Chen <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2025

从 v8.5.5 和 v9.0.0 起,针对部分原本需要 Reorg-Data 的列类型变更,TiDB 优化了执行效率。如果当前会话的 [SQL 模式](/sql-mode.md)为严格模式(即 `sql_mode` 值包含 `STRICT_TRANS_TABLES``STRICT_ALL_TABLES`),TiDB 在进行以下类型变更时,会预先检查类型转换过程中是否存在数据截断风险,若不存在数据截断风险,TiDB 将不再进行表数据重建,仅重建受影响的索引:

- 整数类型之间的变更(例如 `BIGINT``INT`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个场景下,是不是不需要重建索引?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要。之前需要

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 5, 2026

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt January 5, 2026 03:23
`ALTER TABLE .. MODIFY COLUMN` 语句用于修改已有表上的列,包括列的数据类型和属性。若要同时重命名,可改用 [`CHANGE COLUMN`](/sql-statements/sql-statement-change-column.md) 语句。

从 v5.1.0 版本起,TiDB 开始支持 Reorg 类型变更,包括但不限于:
从 v5.1.0 起,TiDB 支持需要 Reorg-Data 的列类型变更。这类变更在执行过程中会重建表中现有的所有数据,包括读取原始数据、按照新的数据格式进行处理,以及重新写入表中。由于需要处理全表数据,Reorg-Data 操作通常较为耗时,其执行时间与表中的数据量成正比。
Copy link
Collaborator

@qiancai qiancai Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#reorg-data-change 里只有一个 INT -> VARCHAR 的示例,不能成为 Reorg-Data 的定义,或者可以把 “需要 Reorg-Data 的列类型变更” 修改为 “需要 Reorg-Data(重新表数据)的列类型变更"?

@qiancai qiancai mentioned this pull request Jan 6, 2026
14 tasks
github-actions bot added a commit to qiancai/docs that referenced this pull request Jan 6, 2026
Synced from: pingcap/docs-cn#21110
Target PR: pingcap#22268
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2026

@wjhuang2016: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 49dc3f9 link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Oreoxmt Oreoxmt self-requested a review January 6, 2026 07:37
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 6, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-06 07:38:50.067673289 +0000 UTC m=+687885.885981711: ☑️ agreed by Oreoxmt.

@qiancai qiancai added the v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants